Support shuffle_vector_exprt in goto programs #6645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
chris-ryder,
kroening and
peterschrammel
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #6645 +/- ##
========================================
Coverage 76.73% 76.73%
========================================
Files 1579 1579
Lines 181999 182012 +13
========================================
+ Hits 139652 139665 +13
Misses 42347 42347
Continue to review full report at Codecov.
|
de4557f added support for _builtin_shuffle/__builtin_shufflevector via a shuffle_vector_exprt. This expression, however, was lowered right away in the C front end, making it unavailable to other language front-ends. By moving the lowering to `remove_vector` there no longer is such a limitation. Kani will be able to use it directly for Rust programs. Regression test cbmc/gcc_vector3 continues to pass, demonstrating that processing via the C front-end works as before. Fixes: diffblue#6297
tautschnig
force-pushed
the
features/shuffle_vector-middle-end
branch
from
9216194 to
eec8e61
Compare
chris-ryder
approved these changes
Feb 8, 2022
kroening
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
de4557f added support for _builtin_shuffle/__builtin_shufflevector via
a shuffle_vector_exprt. This expression, however, was lowered right away
in the C front end, making it unavailable to other language front-ends.
By moving the lowering to
remove_vectorthere no longer is such alimitation. Kani will be able to use it directly for Rust programs.
Regression test cbmc/gcc_vector3 continues to pass, demonstrating that
processing via the C front-end works as before.
Fixes: #6297